1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
|
package proxy_test
import (
"io"
"net/http"
"net/http/httptest"
"os"
"strings"
"testing"
"time"
"github.com/shiv/internal/events"
"github.com/shiv/internal/proxy"
"github.com/shiv/internal/store"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
// newTestStore opens a temp SQLite store and registers cleanup.
func newTestStore(t *testing.T) *store.Store {
t.Helper()
f, err := os.CreateTemp("", "shiv-proxy-test-*.shiv")
require.NoError(t, err)
f.Close()
t.Cleanup(func() { os.Remove(f.Name()) })
projectStore, err := store.Open(f.Name())
require.NoError(t, err)
t.Cleanup(func() { projectStore.Close() })
return projectStore
}
// newTestBus creates a bus wired to the given store — mirrors production wiring.
func newTestBus(t *testing.T, st *store.Store) *events.Bus {
t.Helper()
bus := events.NewBus()
bus.Register(st.Intercept)
bus.Register(st)
return bus
}
// newTestProxy creates a Proxy wired to an events.Bus.
// The proxy is wired as an http.Handler so we can call it via httptest without
// binding a real port.
func newTestProxy(t *testing.T, bus *events.Bus) *proxy.Proxy {
t.Helper()
p, err := proxy.New("127.0.0.1:0", bus)
require.NoError(t, err)
return p
}
// upstreamServer starts a simple upstream that echoes status + body.
func upstreamServer(t *testing.T, status int, body string) *httptest.Server {
t.Helper()
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.WriteHeader(status)
io.WriteString(w, body)
}))
t.Cleanup(srv.Close)
return srv
}
// ── HTTP forwarding ───────────────────────────────────────────────────────────
func TestServeHTTP_ForwardsRequestAndReturnsResponse(t *testing.T) {
st := newTestStore(t)
upstream := upstreamServer(t, http.StatusOK, "hello proxy")
p := newTestProxy(t, newTestBus(t, st))
req := httptest.NewRequest(http.MethodGet, upstream.URL+"/test", nil)
req.RequestURI = upstream.URL + "/test"
w := httptest.NewRecorder()
p.ServeHTTP(w, req)
assert.Equal(t, http.StatusOK, w.Code)
assert.Equal(t, "hello proxy", w.Body.String())
}
func TestServeHTTP_ForwardsPostWithBody(t *testing.T) {
st := newTestStore(t)
var receivedBody string
upstream := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
b, _ := io.ReadAll(r.Body)
receivedBody = string(b)
w.WriteHeader(http.StatusCreated)
}))
t.Cleanup(upstream.Close)
p := newTestProxy(t, newTestBus(t, st))
body := `{"name":"test"}`
req := httptest.NewRequest(http.MethodPost, upstream.URL+"/api", strings.NewReader(body))
req.Header.Set("Content-Type", "application/json")
w := httptest.NewRecorder()
p.ServeHTTP(w, req)
assert.Equal(t, http.StatusCreated, w.Code)
assert.Equal(t, body, receivedBody)
}
func TestServeHTTP_LogsTransactionToStore(t *testing.T) {
st := newTestStore(t)
upstream := upstreamServer(t, http.StatusOK, "logged")
p := newTestProxy(t, newTestBus(t, st))
req := httptest.NewRequest(http.MethodGet, upstream.URL+"/logged", nil)
w := httptest.NewRecorder()
p.ServeHTTP(w, req)
// Give the store a moment to write (it's async via channel)
time.Sleep(50 * time.Millisecond)
txs, err := st.TransactionsPage(0, store.TransactionFilter{ShowOutScope: true})
require.NoError(t, err)
require.Len(t, txs, 1)
assert.Equal(t, "GET", txs[0].Method)
assert.Equal(t, http.StatusOK, txs[0].StatusCode)
}
func TestServeHTTP_ResponseHeadersPassedThrough(t *testing.T) {
st := newTestStore(t)
upstream := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.Header().Set("X-Custom-Header", "custom-value")
w.WriteHeader(http.StatusOK)
}))
t.Cleanup(upstream.Close)
p := newTestProxy(t, newTestBus(t, st))
req := httptest.NewRequest(http.MethodGet, upstream.URL, nil)
w := httptest.NewRecorder()
p.ServeHTTP(w, req)
assert.Equal(t, "custom-value", w.Header().Get("X-Custom-Header"))
}
func TestServeHTTP_CacheHeadersStripped(t *testing.T) {
st := newTestStore(t)
upstream := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.Header().Set("ETag", `"abc123"`)
w.Header().Set("Cache-Control", "max-age=3600")
w.WriteHeader(http.StatusOK)
}))
t.Cleanup(upstream.Close)
p := newTestProxy(t, newTestBus(t, st))
req := httptest.NewRequest(http.MethodGet, upstream.URL, nil)
w := httptest.NewRecorder()
p.ServeHTTP(w, req)
assert.Empty(t, w.Header().Get("ETag"))
assert.Equal(t, "no-store, no-cache, must-revalidate", w.Header().Get("Cache-Control"))
}
func TestServeHTTP_UpstreamError_ReturnsBadGateway(t *testing.T) {
st := newTestStore(t)
p := newTestProxy(t, newTestBus(t, st))
// Point at a port that is not listening
req := httptest.NewRequest(http.MethodGet, "http://127.0.0.1:1/", nil)
w := httptest.NewRecorder()
p.ServeHTTP(w, req)
assert.Equal(t, http.StatusBadGateway, w.Code)
}
// ── Intercept gate ────────────────────────────────────────────────────────────
func TestServeHTTP_InterceptDrop_ReturnsForbidden(t *testing.T) {
st := newTestStore(t)
upstream := upstreamServer(t, http.StatusOK, "should not reach")
p := newTestProxy(t, newTestBus(t, st))
st.Intercept.SetEnabled(true)
// Drain the intercept queue and drop the request in a goroutine
go func() {
pending := <-st.Intercept.Queue()
pending.Reply <- store.Decision{Forward: false}
}()
req := httptest.NewRequest(http.MethodGet, upstream.URL, nil)
w := httptest.NewRecorder()
p.ServeHTTP(w, req)
assert.Equal(t, http.StatusForbidden, w.Code)
}
func TestServeHTTP_InterceptForward_ModifiedRequest(t *testing.T) {
st := newTestStore(t)
var receivedHeader string
upstream := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
receivedHeader = r.Header.Get("X-Injected")
w.WriteHeader(http.StatusOK)
}))
t.Cleanup(upstream.Close)
p := newTestProxy(t, newTestBus(t, st))
st.Intercept.SetEnabled(true)
go func() {
pending := <-st.Intercept.Queue()
pending.Request.Header.Set("X-Injected", "intercepted")
pending.Reply <- store.Decision{
Forward: true,
Request: pending.Request,
Body: pending.Body,
}
}()
req := httptest.NewRequest(http.MethodGet, upstream.URL, nil)
w := httptest.NewRecorder()
p.ServeHTTP(w, req)
assert.Equal(t, http.StatusOK, w.Code)
assert.Equal(t, "intercepted", receivedHeader)
}
|
